git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] use strbuf_addstr() for adding constant strings to a strbuf, part 2

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Sep 15, 2016, 23:47 UTC
Message-ID
<20160915234731.3oqd6x7zxtcxuk3h@vauxhall.crustytoothpaste.net>
In-Reply-To
<f7294ac5-8302-03fb-d756-81a1c029a813@web.de>
On Thu, Sep 15, 2016 at 08:31:00PM +0200, René Scharfe wrote:
Show 9 quoted lines
> Replace uses of strbuf_addf() for adding strings with more lightweight
> strbuf_addstr() calls.  This makes the intent clearer and avoids
> potential issues with printf format specifiers.
> 
> 02962d36845b89145cd69f8bc65e015d78ae3434 already converted six cases,
> this patch covers eleven more.
> 
> A semantic patch for Coccinelle is included for easier checking for
> new cases that might be introduced in the future.

I think all three of these patches look good. I'm glad to see us getting better use out of Coccinelle.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
Previous: René Scharfe
Message 10 of 10 in “use strbuf_addstr() for adding constant strings to a strbuf, part 2”
  1. use strbuf_addstr() for adding constant strings to a strbuf, part 2René Scharfe, Sep 15, 2016
  2. Jeff KingSep 15, 2016
  3. Junio C HamanoSep 15, 2016
  4. Jeff KingSep 15, 2016
  5. René ScharfeSep 15, 2016
  6. Junio C HamanoSep 15, 2016
  7. René ScharfeSep 15, 2016
  8. Junio C HamanoSep 15, 2016
  9. René ScharfeOct 2, 2016
  10. brian m. carlsonSep 15, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.