From: brian m. carlson Date: Thu, 15 Sep 2016 23:47:31 GMT Subject: Re: [PATCH] use strbuf_addstr() for adding constant strings to a strbuf, part 2 Message-ID: <20160915234731.3oqd6x7zxtcxuk3h@vauxhall.crustytoothpaste.net> In-Reply-To: On Thu, Sep 15, 2016 at 08:31:00PM +0200, René Scharfe wrote: > Replace uses of strbuf_addf() for adding strings with more lightweight > strbuf_addstr() calls. This makes the intent clearer and avoids > potential issues with printf format specifiers. > > 02962d36845b89145cd69f8bc65e015d78ae3434 already converted six cases, > this patch covers eleven more. > > A semantic patch for Coccinelle is included for easier checking for > new cases that might be introduced in the future. I think all three of these patches look good. I'm glad to see us getting better use out of Coccinelle. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204