git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] limit the size of the packs we receive

From
Jeff King <peff@peff.net>
Date
Aug 18, 2016, 13:47 UTC
Message-ID
<20160818134727.qqfsxpmek73dgi5h@sigill.intra.peff.net>
In-Reply-To
<20160818131553.22580-1-chriscool@tuxfamily.org>
On Thu, Aug 18, 2016 at 03:15:50PM +0200, Christian Couder wrote:
Show 32 quoted lines
> Diff with previous v1 version
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> diff --git a/t/t5546-push-limits.sh b/t/t5546-push-limits.sh
> index b38d508..09e958f 100755
> --- a/t/t5546-push-limits.sh
> +++ b/t/t5546-push-limits.sh
> @@ -11,11 +11,11 @@ test_expect_success 'create remote repository' '
>  # When the limit is 1, `git receive-pack` will call `git index-pack`.
>  # When the limit is 10, `git receive-pack` will call `git unpack-objects`.
>  
> -while read unpacklimit filesize filename
> +while read unpacklimit filesize filename seed
>  do
>  
>  	test_expect_success "create known-size ($filesize bytes) commit '$filename'" '
> -		test-genrandom foo "$filesize" >"$filename" &&
> +		test-genrandom "$seed" "$filesize" >"$filename" &&
>  		git add "$filename" &&
>  		test_commit "$filename"
>  	'
> @@ -35,8 +35,8 @@ do
>  	'
>  
>  done <<\EOF
> -1 1024 one-k-file
> -10 2048 two-k-file
> +1 1024 one-k-file foo
> +10 1024 other-one-k-file bar
>  EOF
>  
>  test_done

This is still not quite what I would have written, but I don't think it's worth arguing over.

This version looks OK to me. Thanks.
-Peff
Previous: Christian Couder
Message 7 of 7 in “limit the size of the packs we receive”
  1. 0/3 limit the size of the packs we receiveChristian Couder, Aug 18, 2016
  2. 3/3 receive-pack: allow a maximum input size to be specifiedChristian Couder, Aug 18, 2016
  3. Junio C HamanoAug 18, 2016
  4. Jeff KingAug 18, 2016
  5. 2/3 unpack-objects: add --max-input-size=<size> optionChristian Couder, Aug 18, 2016
  6. 1/3 index-pack: add --max-input-size=<size> optionChristian Couder, Aug 18, 2016
  7. Jeff KingAug 18, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.