From: Jeff King <peff@peff.net>
Date: Thu, 18 Aug 2016 13:47:27 GMT
Subject: Re: [PATCH v2 0/3] limit the size of the packs we receive
Message-ID: <20160818134727.qqfsxpmek73dgi5h@sigill.intra.peff.net>
In-Reply-To: <20160818131553.22580-1-chriscool@tuxfamily.org>

On Thu, Aug 18, 2016 at 03:15:50PM +0200, Christian Couder wrote:

> Diff with previous v1 version
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> diff --git a/t/t5546-push-limits.sh b/t/t5546-push-limits.sh
> index b38d508..09e958f 100755
> --- a/t/t5546-push-limits.sh
> +++ b/t/t5546-push-limits.sh
> @@ -11,11 +11,11 @@ test_expect_success 'create remote repository' '
>  # When the limit is 1, `git receive-pack` will call `git index-pack`.
>  # When the limit is 10, `git receive-pack` will call `git unpack-objects`.
>  
> -while read unpacklimit filesize filename
> +while read unpacklimit filesize filename seed
>  do
>  
>  	test_expect_success "create known-size ($filesize bytes) commit '$filename'" '
> -		test-genrandom foo "$filesize" >"$filename" &&
> +		test-genrandom "$seed" "$filesize" >"$filename" &&
>  		git add "$filename" &&
>  		test_commit "$filename"
>  	'
> @@ -35,8 +35,8 @@ do
>  	'
>  
>  done <<\EOF
> -1 1024 one-k-file
> -10 2048 two-k-file
> +1 1024 one-k-file foo
> +10 1024 other-one-k-file bar
>  EOF
>  
>  test_done

This is still not quite what I would have written, but I don't think
it's worth arguing over.

This version looks OK to me. Thanks.

-Peff