git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jul 2016, #02; Wed, 6)

From
Charles Bailey <charles@hashpling.org>
Date
Jul 7, 2016, 21:34 UTC
Message-ID
<20160707213426.GA20572@hashpling.org>
In-Reply-To
<xmqqshvlnnzb.fsf@gitster.mtv.corp.google.com>
On Thu, Jul 07, 2016 at 02:21:28PM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> Charles Bailey <charles@hashpling.org> writes:
> 
> > I just wanted to clarify what was actually fixed. The actual bug that
> > was reported and fixed was the fact that 'git grep' (without --cached)
> > wasn't searching the contents of files in the working tree if the index
> > entry had the "intent to add" bit set.
> 
> Ouch, you are absolutely right.
> 
>  Git does not know what the contents in the index should be for a
>  path added with "git add -N" yet, so "git grep --cached" should not
>  show hits (or show lack of hits, with -L) in such a path, but that
>  logic does not apply to "git grep", i.e. searching in the working
>  tree files.  But we did so by mistake, which has been corrected.
> 
> perhaps?
Yes, that reads like an accurate summary to me.
Previous: Junio C Hamano
Message 4 of 4 in “What's cooking in git.git (Jul 2016, #02; Wed, 6)”
  1. Junio C HamanoJul 6, 2016
  2. Charles BaileyJul 7, 2016
  3. Junio C HamanoJul 7, 2016
  4. Charles BaileyJul 7, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.