From: Charles Bailey <charles@hashpling.org>
Date: Thu, 07 Jul 2016 21:34:26 GMT
Subject: Re: What's cooking in git.git (Jul 2016, #02; Wed, 6)
Message-ID: <20160707213426.GA20572@hashpling.org>
In-Reply-To: <xmqqshvlnnzb.fsf@gitster.mtv.corp.google.com>

On Thu, Jul 07, 2016 at 02:21:28PM -0700, Junio C Hamano wrote:
> Charles Bailey <charles@hashpling.org> writes:
> 
> > I just wanted to clarify what was actually fixed. The actual bug that
> > was reported and fixed was the fact that 'git grep' (without --cached)
> > wasn't searching the contents of files in the working tree if the index
> > entry had the "intent to add" bit set.
> 
> Ouch, you are absolutely right.
> 
>  Git does not know what the contents in the index should be for a
>  path added with "git add -N" yet, so "git grep --cached" should not
>  show hits (or show lack of hits, with -L) in such a path, but that
>  logic does not apply to "git grep", i.e. searching in the working
>  tree files.  But we did so by mistake, which has been corrected.
> 
> perhaps?

Yes, that reads like an accurate summary to me.