git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: use VCSSVN_LIB to refer to svn library

From
Jeff King <peff@peff.net>
Date
Jul 1, 2016, 07:59 UTC
Message-ID
<20160701075944.GA20736@sigill.intra.peff.net>
In-Reply-To
<20160701075651.GA20653@sigill.intra.peff.net>
We have an abstracted variable; let's use it consistently.
Signed-off-by: Jeff King <peff@peff.net>
---
On top of the cleanup earlier in the thread.

I actually wonder if we should drop the vcs-svn code entirely. The last update that wasn't just part of a "I'm grepping the whole code base to change this interface" patch was almost 4 years ago, and AFAICT it never reached a shippable point (we _do_ actually install git-remote-testsvn, but given the name, I sort of assume nobody is using it).

But I don't want to step on the toes of anybody who actually is using it, or is planning to work on it more.

 Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 22815a2..4579eab 100644
--- a/Makefile
+++ b/Makefile
@@ -2225,9 +2225,9 @@ perf: all
 
 .PHONY: test perf
 
-t/helper/test-line-buffer$X: vcs-svn/lib.a
+t/helper/test-line-buffer$X: $(VCSSVN_LIB)
 
-t/helper/test-svn-fe$X: vcs-svn/lib.a
+t/helper/test-svn-fe$X: $(VCSSVN_LIB)
 
 .PRECIOUS: $(TEST_OBJS)
 
-- 
2.9.0.317.g65b4e7c
Previous: Jeff King
Message 2 of 2 in “Makefile: drop extra dependencies for test helpers”
  1. Makefile: drop extra dependencies for test helpersJeff King, Jul 1, 2016
  2. Makefile: use VCSSVN_LIB to refer to svn libraryJeff King, Jul 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.