git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: drop extra dependencies for test helpers

From
Jeff King <peff@peff.net>
Date
Jul 1, 2016, 07:56 UTC
Message-ID
<20160701075651.GA20653@sigill.intra.peff.net>

A few test-helpers have Makefile dependencies on specific object files. But since these files are part of libgit.a (which all of the helpers link against), the inclusion is simply redundant.

These were once necessary, but became redundant due to 5c5ba73 (Makefile: Use generic rule to build test programs, 2007-05-31), which added the $(GITLIBS) dependency (but didn't prune the extra dependency lines). Later commits then cargo-culted the practice (e.g., b4285c7).

Note that we _do_ need to leave the dependencies on the svn library, as that is not part of the usual link command.

Signed-off-by: Jeff King <peff@peff.net>
---
Just a cleanup I noticed while working on the common-main series.
 Makefile | 8 --------
 1 file changed, 8 deletions(-)
diff --git a/Makefile b/Makefile
index de5a030..22815a2 100644
--- a/Makefile
+++ b/Makefile
@@ -2225,16 +2225,8 @@ perf: all
 
 .PHONY: test perf
 
-t/helper/test-ctype$X: ctype.o
-
-t/helper/test-date$X: date.o ctype.o
-
-t/helper/test-delta$X: diff-delta.o patch-delta.o
-
 t/helper/test-line-buffer$X: vcs-svn/lib.a
 
-t/helper/test-parse-options$X: parse-options.o parse-options-cb.o
-
 t/helper/test-svn-fe$X: vcs-svn/lib.a
 
 .PRECIOUS: $(TEST_OBJS)
-- 
2.9.0.317.g65b4e7c
Next: Jeff King
Message 1 of 2 in “Makefile: drop extra dependencies for test helpers”
  1. Makefile: drop extra dependencies for test helpersJeff King, Jul 1, 2016
  2. Makefile: use VCSSVN_LIB to refer to svn libraryJeff King, Jul 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.