git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/4] clarify %f documentation

From
Joey Hess <joeyh@joeyh.name>
Date
Jun 17, 2016, 22:43 UTC
Message-ID
<20160617224345.GA26764@kitenet.net>
In-Reply-To
<xmqqshwbzfab.fsf@gitster.mtv.corp.google.com>

It's natural to expect %f to be an actual file on disk; help avoid that mistake.

Signed-off-by: Joey Hess <joeyh@joeyh.name>
---

This patch series was meant to contain 5 patches; here's the missing one. This patch will apply cleanly on top of v2.9.0.

 Documentation/gitattributes.txt | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt
index e3b1de8..145dd10 100644
--- a/Documentation/gitattributes.txt
+++ b/Documentation/gitattributes.txt
@@ -374,6 +374,11 @@ substitution.  For example:
 	smudge = git-p4-filter --smudge %f
 ------------------------
 
+Note that "%f" is the name of the path that is being worked on. Depending
+on the version that is being filtered, the corresponding file on disk may
+not exist, or may have different contents. So, smudge and clean commands
+should not try to access the file on disk, but only act as filters on the
+content provided to them on standard input.
 
 Interaction between checkin/checkout attributes
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-- 
2.8.1
Previous: Junio C Hamano
Message 8 of 8 in “extend smudge/clean filters with direct file access”
  1. 0/4 extend smudge/clean filters with direct file accessJoey Hess, Jun 17, 2016
  2. 4/4 warn on unusable smudgeToFile/cleanFromFile configJoey Hess, Jun 17, 2016
  3. 3/4 use smudgeToFile in git checkout etcJoey Hess, Jun 17, 2016
  4. 1/4 add smudgeToFile and cleanFromFile filter configsJoey Hess, Jun 17, 2016
  5. 2/4 use cleanFromFile in git addJoey Hess, Jun 17, 2016
  6. Joey HessJun 17, 2016
  7. Junio C HamanoJun 17, 2016
  8. 0/4 clarify %f documentationJoey Hess, Jun 17, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.