git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/4] extend smudge/clean filters with direct file access

From
Joey Hess <joeyh@joeyh.name>
Date
Jun 17, 2016, 20:31 UTC
Message-ID
<1466195481-23209-1-git-send-email-joeyh@joeyh.name>
Reroll of this patch set with changes:
* Renamed the new filter drivers for consistency with other configs.
* Improved documentation with feedback from Junio and others.
* Eliminated %p and instead append the filename to the commands
  (separated by a space).
* Fixed an FD leak and a space leak.
* Only use smudgeToFile with regular files, not symlinks.
* After running the smudgeToFile command, double-check that the
  expected file is present, in case the command was buggy and deleted it.
* Added a warning message when the new filter commands are configured
  but the old ones are not, so that the user knows it's refusing to use
  their configuration.

There's been good and helpful documentation and interface review, but some more code review would be good! Also, git-annex has a improved-smudge-filters branch now that demonstrates this interface.

Joey Hess (4):
  add smudgeToFile and cleanFromFile filter configs
  use cleanFromFile in git add
  use smudgeToFile in git checkout etc
  warn on unusable smudgeToFile/cleanFromFile config
 Documentation/config.txt        |  18 +++++-
 Documentation/gitattributes.txt |  37 ++++++++++++
 convert.c                       | 126 +++++++++++++++++++++++++++++++++++-----
 convert.h                       |  10 ++++
 entry.c                         |  37 +++++++++---
 sha1_file.c                     |  42 ++++++++++++--
 t/t0021-conversion.sh           |  64 ++++++++++++++++++++
 7 files changed, 304 insertions(+), 30 deletions(-)
-- 
2.8.1
Next: Joey Hess
Message 1 of 8 in “extend smudge/clean filters with direct file access”
  1. 0/4 extend smudge/clean filters with direct file accessJoey Hess, Jun 17, 2016
  2. 4/4 warn on unusable smudgeToFile/cleanFromFile configJoey Hess, Jun 17, 2016
  3. 3/4 use smudgeToFile in git checkout etcJoey Hess, Jun 17, 2016
  4. 1/4 add smudgeToFile and cleanFromFile filter configsJoey Hess, Jun 17, 2016
  5. 2/4 use cleanFromFile in git addJoey Hess, Jun 17, 2016
  6. Joey HessJun 17, 2016
  7. Junio C HamanoJun 17, 2016
  8. 0/4 clarify %f documentationJoey Hess, Jun 17, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.