git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 01/10] builtin/commit.c: convert trivial snprintf calls to xsnprintf

From
Jeff King <peff@peff.net>
Date
Jun 3, 2016, 09:04 UTC
Message-ID
<20160603090448.GF28401@sigill.intra.peff.net>
In-Reply-To
<20160603084917.GA28401@sigill.intra.peff.net>
On Fri, Jun 03, 2016 at 04:49:18AM -0400, Jeff King wrote:
> I haven't looked carefully at each call site in detail yet, but from the
> previous rounds of sprintf handling, I'd guess each site falls into one
> of two categories:

So that being said, I did just look at several of them. And I think they _do_ fall into these categories, but I think the solutions don't necessarily. So what I would do is find solutions for each, and then go back and group them by situation and solution-type using "git rebase -i". It may be that you end up with 10 patches, or it may be that you see some patterns. But I think grouping is helpful for reviewers, because it communicates the patterns you found while doing the work.

-Peff
Previous: Jeff KingNext: Ramsay Jones
Message 20 of 21 in “builtin/commit.c: convert trivial snprintf calls to xsnprintf”
  1. 01/10 builtin/commit.c: convert trivial snprintf calls to xsnprintfElia Pinto, Jun 3, 2016
  2. 02/10 builtin/index-pack.c: convert trivial snprintf calls to xsnprintfElia Pinto, Jun 3, 2016
  3. Jeff KingJun 3, 2016
  4. Ramsay JonesJun 3, 2016
  5. Jeff KingJun 3, 2016
  6. 03/10 builtin/tag.c: convert trivial snprintf calls to xsnprintfElia Pinto, Jun 3, 2016
  7. Jeff KingJun 3, 2016
  8. Ramsay JonesJun 3, 2016
  9. 04/10 combine-diff.c: convert trivial snprintf calls to xsnprintfElia Pinto, Jun 3, 2016
  10. Jeff KingJun 3, 2016
  11. 05/10 compat/inet_ntop.c: convert trivial snprintf calls to xsnprintfElia Pinto, Jun 3, 2016
  12. 06/10 diff.c: convert trivial snprintf calls to xsnprintfElia Pinto, Jun 3, 2016
  13. Jeff KingJun 3, 2016
  14. 07/10 fast-import.c: convert trivial snprintf calls to xsnprintfElia Pinto, Jun 3, 2016
  15. 08/10 refs.c: convert trivial snprintf calls to xsnprintfElia Pinto, Jun 3, 2016
  16. 09/10 transport-helper.c: convert trivial snprintf calls to xsnprintfElia Pinto, Jun 3, 2016
  17. 10/10 wrapper.c: convert trivial snprintf calls to xsnprintfElia Pinto, Jun 3, 2016
  18. Jeff KingJun 3, 2016
  19. Jeff KingJun 3, 2016
  20. Jeff KingJun 3, 2016
  21. Ramsay JonesJun 3, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.