[PATCH 04/10] combine-diff.c: convert trivial snprintf calls to xsnprintf
- From
Elia Pinto <gitter.spiros@gmail.com>
- Date
- Jun 3, 2016, 07:47 UTC
- Message-ID
- <20160603074724.12173-4-gitter.spiros@gmail.com>
- In-Reply-To
- <20160603074724.12173-1-gitter.spiros@gmail.com>
With the commits f2f02675 and 5096d490 we have been converted in some files the call from snprintf/sprintf/strcpy to xsnprintf. This patch converts the remaining calls to snprintf with xsnprintf under the following conditions:
- The call to snprintf does not control the outcome of the command or the presence of truncation errors. - A call to snprintf can generate a fatal error, directly or indirectly.
The other few remaining cases in which a call to snprintf can generate a soft error have not been changed.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> --- combine-diff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/combine-diff.c b/combine-diff.c index 8f2313d..a91d9b3 100644 --- a/combine-diff.c +++ b/combine-diff.c @@ -293,7 +293,7 @@ static char *grab_blob(const struct object_id *oid, unsigned int mode, if (S_ISGITLINK(mode)) { blob = xmalloc(100); - *size = snprintf(blob, 100, + *size = xsnprintf(blob, 100, "Subproject commit %s\n", oid_to_hex(oid)); } else if (is_null_oid(oid)) { /* deleted blob */
-- 2.9.0.rc1.265.geb5d750