Re: "git tag --contains <id>" is too chatty, if <id> is invalid
- From
Jeff King <peff@peff.net>
- Date
- Mar 19, 2016, 18:12 UTC
- Message-ID
- <20160319181228.GA9115@sigill.intra.peff.net>
- In-Reply-To
- <CAJj6+1HaVnRcmDHOTDdx=o8a+aXvSi8+LykWzrfx7knE-_3ocg@mail.gmail.com>
On Sat, Mar 19, 2016 at 11:38:09PM +0530, Chirayu Desai wrote:
Show 5 quoted lines
> > You'd teach parse_opt_commits() to store the string _name_ of the > > argument (e.g., using a string_list rather than a commit_list), and then > > later resolve those names into commits. > Gotcha, will need to figure out where exactly would those names be > resolved, can do after following the code path a bit more, can do.
Without looking too closely, I suspect you could do it as the first step in filter_refs(). Or alternatively, add a function to "finalize" the filter state before making queries of it.
-Peff