Re: [RFC] Code reorgnization

From: John Keeping <john@keeping.me.uk>
Date: Mar 17, 2016, 21:43 UTC
Message-ID: <20160317214355.GA32317@serenity.lan>
In-Reply-To: <xmqqy49gzzrf.fsf@gitster.mtv.corp.google.com>

On Thu, Mar 17, 2016 at 12:10:44PM -0700, Junio C Hamano wrote:

Show 19 quoted lines

> Stefan Beller <sbeller@google.com> writes:
> 
> > For now I would just go with 3 directories:
> >
> > non-git/ (or util, helpers, or anything that could be ripped out and be useful
> >     e.g. strbufs, argv-array run-command, lockfile
> > git/ (maybe called lib? All stuff that is pure Git and is used for libgit
> >
> > builtin/ (as we have it today + all that stuff that doesn't go into
> > git/ very well?)
> 
> It is unclear where you want to have standalone programs in the
> above.  I'd say lib/ and src/ for the first two, where lib/ is for
> things that could be lifted without any Git dependencies and src/
> for everything else.
> 
> Aren't there some folks who link directly with our codebase (I am
> thinking about cgit, but hjemli.net/git/cgit does not seem to be
> responding anymore)?

CGit lives at https://git.zx2c4.com/cgit/ these days.

The organisation of the git code shouldn't make a difference since CGit just links with libgit.a, even if it does CGit pulls in git.git as a submodule so it can just fix any problems in the same commit that updates the submodule reference.