git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/1] http: Fix crash when passing malformed URL

From
Jeff King <peff@peff.net>
Date
Mar 16, 2016, 21:29 UTC
Message-ID
<20160316212938.GA4441@sigill.intra.peff.net>
In-Reply-To
<1458125647-32707-1-git-send-email-anton.wuerfel@fau.de>
On Wed, Mar 16, 2016 at 11:54:06AM +0100, Anton Wuerfel wrote:
Show 6 quoted lines
> When passing a malformed URL to http_init() in http.c, git dies from a null
> pointer dereference. An example for a malformed URL is http:/git-scm.com (note
> the single slash after the protocol).
> 
> I could not reproduce this error within any functions of git - I just noticed it
> during development of a git extension together with Phillip Raffeck.
You can reproduce it with:
  git clone https::bogus

Normally we recognize "https://" as the signal to send the URL to the git-remote-https helper, but you can override the helper by specifying "whatever::", and then the rest of the string will be passed to it.

-Peff
Previous: Jeff King
Message 4 of 4 in “http: Fix crash when passing malformed URL”
  1. 0/1 http: Fix crash when passing malformed URLAnton Wuerfel, Mar 16, 2016
  2. 1/1 http: Fix crash when passing malformed URLAnton Wuerfel, Mar 16, 2016
  3. Jeff KingMar 16, 2016
  4. Jeff KingMar 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.