From: Jeff King <peff@peff.net>
Date: Wed, 16 Mar 2016 21:29:38 GMT
Subject: Re: [PATCH 0/1] http: Fix crash when passing malformed URL
Message-ID: <20160316212938.GA4441@sigill.intra.peff.net>
In-Reply-To: <1458125647-32707-1-git-send-email-anton.wuerfel@fau.de>

On Wed, Mar 16, 2016 at 11:54:06AM +0100, Anton Wuerfel wrote:

> When passing a malformed URL to http_init() in http.c, git dies from a null
> pointer dereference. An example for a malformed URL is http:/git-scm.com (note
> the single slash after the protocol).
> 
> I could not reproduce this error within any functions of git - I just noticed it
> during development of a git extension together with Phillip Raffeck.

You can reproduce it with:

  git clone https::bogus

Normally we recognize "https://" as the signal to send the URL to the
git-remote-https helper, but you can override the helper by specifying
"whatever::", and then the rest of the string will be passed to it.

-Peff