git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 09/10] setup: drop repository_format_version global

From
Jeff King <peff@peff.net>
Date
Mar 11, 2016, 22:37 UTC
Message-ID
<20160311223718.GI449@sigill.intra.peff.net>
In-Reply-To
<20160311223620.GA7963@sigill.intra.peff.net>

Nobody reads this anymore, and they're not likely to; the interesting thing is whether or not we passed check_repository_format(), and possibly the individual "extension" variables.

Signed-off-by: Jeff King <peff@peff.net>
---
 cache.h       | 1 -
 environment.c | 1 -
 setup.c       | 1 -
 3 files changed, 3 deletions(-)
diff --git a/cache.h b/cache.h
index 7704bc6..bec6db5 100644
--- a/cache.h
+++ b/cache.h
@@ -747,7 +747,6 @@ extern int grafts_replace_parents;
  */
 #define GIT_REPO_VERSION 0
 #define GIT_REPO_VERSION_READ 1
-extern int repository_format_version;
 extern int repository_format_precious_objects;
 
 struct repository_format {
diff --git a/environment.c b/environment.c
index 8b8c8e8..d9e3861 100644
--- a/environment.c
+++ b/environment.c
@@ -25,7 +25,6 @@ int log_all_ref_updates = -1; /* unspecified */
 int warn_ambiguous_refs = 1;
 int warn_on_object_refname_ambiguity = 1;
 int ref_paranoia = -1;
-int repository_format_version;
 int repository_format_precious_objects;
 const char *git_commit_encoding;
 const char *git_log_output_encoding;
diff --git a/setup.c b/setup.c
index fbe7ec1..1314c17 100644
--- a/setup.c
+++ b/setup.c
@@ -428,7 +428,6 @@ static int check_repository_format_gently(const char *gitdir, int *nongit_ok)
 		die("%s", err.buf);
 	}
 
-	repository_format_version = candidate.version;
 	repository_format_precious_objects = candidate.precious_objects;
 	string_list_clear(&candidate.unknown_extensions, 0);
 	if (!has_common) {
-- 
2.8.0.rc2.328.g39e2a47
Previous: Jeff KingNext: Jeff King
Message 11 of 12 in “cleaning up check_repository_format_gently”
  1. 0/10 cleaning up check_repository_format_gentlyJeff King, Mar 11, 2016
  2. 01/10 setup: document check_repository_format()Jeff King, Mar 11, 2016
  3. 02/10 wrap shared_repository global in get/set accessorsJeff King, Mar 11, 2016
  4. 03/10 lazily load core.sharedrepositoryJeff King, Mar 11, 2016
  5. 04/10 check_repository_format_gently: stop using git_config_earlyJeff King, Mar 11, 2016
  6. 05/10 config: drop git_config_earlyJeff King, Mar 11, 2016
  7. Junio C HamanoMar 11, 2016
  8. 06/10 setup: refactor repo format reading and verificationJeff King, Mar 11, 2016
  9. 07/10 init: use setup.c's repo version verificationJeff King, Mar 11, 2016
  10. 08/10 setup: unify repository version callbacksJeff King, Mar 11, 2016
  11. 09/10 setup: drop repository_format_version globalJeff King, Mar 11, 2016
  12. 10/10 verify_repository_format: mark messages for translationJeff King, Mar 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.