git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/10] cleaning up check_repository_format_gently

From
Jeff King <peff@peff.net>
Date
Mar 11, 2016, 22:36 UTC
Message-ID
<20160311223620.GA7963@sigill.intra.peff.net>
This is a re-roll of:
  http://article.gmane.org/gmane.comp.version-control.git/288017
The changes from v1 are:
  - dropped original 10/10 that got rid of GIT_REPO_VERSION defines
    (David mentioned that he's going to be expanding their use, so the
    argument that they are not used does not make sense)
  - added new 10/10 marking messages for translation (suggested by Duy)
  - added int return value to new read_repository_format(); this is
    redundant with the error value returned in the struct, but allows a
    more idiomatic:
      if (read_repository_format(&format, file) < 0)
         ...
  - drop confusing comment from 06/10, in favor of a better explanation
    in the commit message
  - fixed newline regression from v1 when printing out unknown
    extensions. Note that because we switch from looping over warning()
    or die() to sticking errors into a strbuf (which the caller then
    feeds to warning/die), the format changed a bit.  Naively, it would
    become:
      warning: unknown extension: foo
      unknown:extension: bar
    but I turned it into the more pleasant:
      warning: unknown repository extensions found:
              foo
              bar
    I think it would be better still if warning() was smart enough to
    stick its prefix in front of all lines (like advise() does). But
    that's outside the scope of this series. And it probably doesn't
    matter much either way; this is not a message we'd expect anyone to
    see routinely.
  [01/10]: setup: document check_repository_format()
  [02/10]: wrap shared_repository global in get/set accessors
  [03/10]: lazily load core.sharedrepository
  [04/10]: check_repository_format_gently: stop using git_config_early
  [05/10]: config: drop git_config_early
  [06/10]: setup: refactor repo format reading and verification
  [07/10]: init: use setup.c's repo version verification
  [08/10]: setup: unify repository version callbacks
  [09/10]: setup: drop repository_format_version global
  [10/10]: verify_repository_format: mark messages for translation
-Peff
Next: Jeff King
Message 1 of 12 in “cleaning up check_repository_format_gently”
  1. 0/10 cleaning up check_repository_format_gentlyJeff King, Mar 11, 2016
  2. 01/10 setup: document check_repository_format()Jeff King, Mar 11, 2016
  3. 02/10 wrap shared_repository global in get/set accessorsJeff King, Mar 11, 2016
  4. 03/10 lazily load core.sharedrepositoryJeff King, Mar 11, 2016
  5. 04/10 check_repository_format_gently: stop using git_config_earlyJeff King, Mar 11, 2016
  6. 05/10 config: drop git_config_earlyJeff King, Mar 11, 2016
  7. Junio C HamanoMar 11, 2016
  8. 06/10 setup: refactor repo format reading and verificationJeff King, Mar 11, 2016
  9. 07/10 init: use setup.c's repo version verificationJeff King, Mar 11, 2016
  10. 08/10 setup: unify repository version callbacksJeff King, Mar 11, 2016
  11. 09/10 setup: drop repository_format_version globalJeff King, Mar 11, 2016
  12. 10/10 verify_repository_format: mark messages for translationJeff King, Mar 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.