Re: [PATCH] index-pack: correct --keep[=<msg>]
On Thu, Mar 03, 2016 at 11:14:46AM -0800, Junio C Hamano wrote:
Show 11 quoted lines
> When 592ce208 (index-pack: use strip_suffix to avoid magic numbers,
> 2014-06-30) refactored the code to derive names of .idx and .keep
> files from the name of .pack file, a copy-and-paste typo crept in,
> mistakingly attempting to create and store the keep message file in
> the .idx file we just created, instead of .keep file.
>
> As we create the .keep file with O_CREAT|O_EXCL, and we do so after
> we write the .idx file, we luckily do not clobber the .idx file, but
> because we deliberately ignored EEXIST when creating .keep file
> (which is justifiable because only the existence of .keep file
> matters), nobody noticed this mistake so far.
Eek. Sorry about that. Your explanation and fix looks obviously correct.
-Peff
Jeff King <peff@peff.net>