Re: bug: git submodule add fails when .git is a symlink

From: Jeff King <peff@peff.net>
Date: Mar 2, 2016, 08:49 UTC
Message-ID: <20160302084904.GA30295@sigill.intra.peff.net>
In-Reply-To: <20160301231720.GB3731@kitenet.net>

On Tue, Mar 01, 2016 at 07:17:20PM -0400, Joey Hess wrote:

Show 12 quoted lines

> Junio C Hamano wrote:
> > A more pertinent question may be which version of Git did the above
> > ever work, I guess.  We fairly liberally chdir around and I do not
> > think we deliberately avoid assuming that "cd .git && cd .." might
> > not come back to the original directory, for example, so I wouldn't
> > be surprised if it never worked.
> 
> IIRC git used symlinks for .git in submodules before version 1.7.8, so I
> guess that older versions supported that pretty well.
> 
> This one case is the only time I've seen a symlink for .git present a
> problem so far.

Fortunately you provided a simple reproduction case, so it is easy to bisect. It did work in v1.7.8, and broke in d75219b (submodules: always use a relative path from gitdir to work tree, 2012-03-04). Not surprising, I guess. It presumably worked before only because we were using absolute paths.

-Peff