Re: bug: git submodule add fails when .git is a symlink

From: Joey Hess <id@joeyh.name>
Date: Mar 1, 2016, 23:14 UTC
Message-ID: <20160301231422.GA3731@kitenet.net>
In-Reply-To: <CAGZ79kbV9y6nDuBgqLbzQ=xaroG_uF8RF6gqzk=unJ-9rrtvfw@mail.gmail.com>

Stefan Beller wrote:

Show 6 quoted lines

> To elaborate on that: Starting in 2.7 parts of the submodule stuff
> has been rewritten in C, in 2.8 even more and there is more in flight for
>  > 2.8.
> 
> However your bug is also to be found in 2.6, which doesn't contain any
> recent rewrites, so it is a rather long standing bug, I would presume.

Yes, I saw it with 2.7.0, but I think the user who reported it was on 2.6.

> As a workaround for now:
> 
>     echo "gitdir: ../gitdir/.git" > .git

Not an option in our particular situation, unfortunately.

I wonder if the miscalculated ../../../somedir could cause git to access files outside the git repos?

-- 
see shy jo