Re: [PATCH v3 17/20] refs: allow ref backend to be set for clone

From: SZEDER Gábor <szeder@ira.uka.de>
Date: Jan 21, 2016, 09:08 UTC
Message-ID: <20160121100820.Horde.5-2HMBAP-1P3hWXbxgxeBsX@webmail.informatik.kit.edu>
In-Reply-To: <1453223161.16226.24.camel@twopensource.com>

Quoting David Turner <dturner@twopensource.com>:

Show 7 quoted lines

> Thanks for the suggestions.
>
> With your permission, I will add:
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
>
> to all three of these patches post-squash.  Is that OK?

Sure...

(But does such a trivial one-liner need a sign-off at all, when it's not a standalone patch?)

Show 31 quoted lines

> On Fri, 2016-01-15 at 12:32 +0100, SZEDER Gábor wrote:
>> Hi,
>>
>> This change is more about 'git clone' than about refs, therefore
>> I think the subject line would be better as:
>>
>>   clone: allow setting alternate ref backend
>>
>> Could you please squash this in to keep the completion script up to
>> date?
>> Is there or will there be a way to list available ref backends, so we
>> could complete possible options for --ref-storage=<TAB>, too?
>>
>> ------ >8 ------
>>
>> Subject: completion: git clone --ref-storage=
>> ---
>> diff --git a/contrib/completion/git-completion.bash
>> b/contrib/completion/git-completion.bash
>> index ab4da7f97917..c970d3c0d0a3 100644
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -1092,6 +1092,7 @@ _git_clone ()
>>  			--depth
>>  			--single-branch
>>  			--branch
>> +			--ref-storage=
>>  			"
>>  		return
>>  		;;
>>