Re: [PATCH v3 0/3] prepare_packed_git(): find more garbage

From: Jeff King <peff@peff.net>
Date: Dec 19, 2015, 02:02 UTC
Message-ID: <20151219020247.GA3098@sigill.intra.peff.net>
In-Reply-To: <1450483600-64091-1-git-send-email-dougk.ff7@gmail.com>

On Fri, Dec 18, 2015 at 06:06:37PM -0600, Doug Kelly wrote:

Show 5 quoted lines

> Corrects the issues found in review by Peff, including simplifying
> the logic in report_helper().  bits_to_msg() would've been an alternate
> solution to that change, however it'll get called by
> real_report_garbage(), so there's no need to call it twice, especially
> when the check we need within report_helper().

OK. The new logic in 1/3 looks fine to me.

Show 5 quoted lines

> I think checking for seen_bits == 0 would be future-proofing should we
> arrive at a file bit not otherwise match it (i.e. file.foo and
> file.bar, but nothing else would cause seen_bits to be zero, but if
> that's the case, we wouldn't have PACKDIR_FILE_IDX or
> PACKDIR_FILE_PACK set, either, and the second half would also match.

Yeah, I think this is sound.

I left a few comments on 3/3. I don't think it's _wrong_, but I think we can be a bit more thorough (and IMHO, a little more maintainable, but others might disagree).

-Peff