[PATCH v3 0/3] prepare_packed_git(): find more garbage
- From
Doug Kelly <dougk.ff7@gmail.com>
- Date
- Dec 19, 2015, 00:06 UTC
- Message-ID
- <1450483600-64091-1-git-send-email-dougk.ff7@gmail.com>
- In-Reply-To
- <20151215232534.GA30998@sigill.intra.peff.net>
Corrects the issues found in review by Peff, including simplifying the logic in report_helper(). bits_to_msg() would've been an alternate solution to that change, however it'll get called by real_report_garbage(), so there's no need to call it twice, especially when the check we need within report_helper().
I think checking for seen_bits == 0 would be future-proofing should we arrive at a file bit not otherwise match it (i.e. file.foo and file.bar, but nothing else would cause seen_bits to be zero, but if that's the case, we wouldn't have PACKDIR_FILE_IDX or PACKDIR_FILE_PACK set, either, and the second half would also match.
Doug Kelly (3): prepare_packed_git(): find more garbage t5304: Add test for .bitmap garbage files gc: Clean garbage .bitmap files from pack dir
builtin/count-objects.c | 16 ++++++---------- builtin/gc.c | 12 ++++++++++-- cache.h | 4 +++- sha1_file.c | 12 +++++++++--- t/t5304-prune.sh | 20 ++++++++++++++++++++ 5 files changed, 48 insertions(+), 16 deletions(-)
-- 2.6.1