Re: What's cooking in git.git (Dec 2015, #05; Tue, 15)
- From
Jeff King <peff@peff.net>
- Date
- Dec 16, 2015, 00:50 UTC
- Message-ID
- <20151216005045.GA31433@sigill.intra.peff.net>
- In-Reply-To
- <xmqq4mfjff9x.fsf@gitster.mtv.corp.google.com>
On Tue, Dec 15, 2015 at 03:44:42PM -0800, Junio C Hamano wrote:
Show 9 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > > > There already was strbuf_getline_crlf(), and I wanted a new name to > > be conservative. > > When I re-read the series, I realize that the existing one had > exactly the same semantics as strbuf_gets(), so I think no risk > would come from reusing that name. Let me try redoing the series > when I find time ;-)
Heh. I just made up that name, not realizing it existed. Looks like it is fairly recent as part of builtin-am, which explains why I hadn't seen it yet.
I agree it looks like it does what you want. Upon reading your first message I thought "eh, did I totally misunderstand the intent of the series?", but it looks like we are on the same page. :)
-Peff