Re: What's cooking in git.git (Dec 2015, #05; Tue, 15)

From: Jeff King <peff@peff.net>
Date: Dec 15, 2015, 23:32 UTC
Message-ID: <20151215233207.GA30294@sigill.intra.peff.net>
In-Reply-To: <xmqq8u4ve3at.fsf@gitster.mtv.corp.google.com>

On Tue, Dec 15, 2015 at 02:48:42PM -0800, Junio C Hamano wrote:

Show 9 quoted lines

> * dk/gc-more-wo-pack (2015-11-24) 3 commits
>  - gc: Clean garbage .bitmap files from pack dir
>  - t5304: Add test for .bitmap garbage files
>  - prepare_packed_git(): find more garbage
> 
>  Follow-on to dk/gc-idx-wo-pack topic, to clean up stale
>  .bitmap and .keep files.
> 
>  Waiting for review.

I just read through and made some comments.

Note that I think there was a re-roll of the first patch after I picked up the original:

  http://article.gmane.org/gmane.comp.version-control.git/281759

Hopefully Doug will re-post the whole series after taking a look at my comments.

Show 10 quoted lines

> * jc/strbuf-gets (2015-10-28) 17 commits
> [...]
> 
>  Teach codepaths that communicate with users by reading text files
>  to be more lenient to editors that write CRLF-terminated lines.
>  Note that this is only about communication with Git, like feeding
>  list of object names from the standard input instead of from the
>  command line, and does not involve files in the working tree.
> 
>  Waiting for review.

I like the intent here, but I was a little disappointed that we end up with two almost identical strbuf functions. But even if the ultimate endgame is to drop back to one, the conservative route is to keep them both until all new code paths have "opted in" to the new behavior. However, I found the naming confusing: it was not at all clear to me which of strbuf_gets and strbuf_getline did the CRLF-munging. Perhaps it would be more obvious if the new one was strbuf_getline_crlf or something. I dunno.

-Peff