Re: [PATCH 1/2] git-p4: support multiple depot paths in p4 submit

From: Sam Hocevar <sam@hocevar.net>
Date: Dec 8, 2015, 11:41 UTC
Message-ID: <20151208114106.GB48528@hocevar.net>
In-Reply-To: <14B51656-26D1-4805-9F07-102CBD81B387@gmail.com>

On Tue, Dec 08, 2015, Lars Schneider wrote:

Show 5 quoted lines

> >   Would a refactor of lib-git-p4.sh (and probably all git-p4 tests) to
> > support multiple depots be acceptable and/or welcome? I prefer to ask
> > before I dig into the task.
> 
> Can you outline your idea a bit? Are you aware of the following way to define client specs: [1] ? Would that help?

   That's the idea, but the bug occurs when the client view looks like this:

     //depot/... //client/dir1/...
     //depot2/... //client/dir2/...

   And is then cloned with (it is not legal in Perforce to specify //...
directly to grab both depots at once):

     git p4 clone --use-client-spec //depot/... //depot2/...

   Then when a file is modified in dir2/, git p4 submit does not elect it
for the changelist. A file in dir1/ will work fine.

   Unfortunately the current test suite assumes everything is under
//depot/ so in order to write a test for this situation there are a few
things to change in lib-git-p4.sh.

Regards,

-- 
Sam.