Re: [PATCH 1/2] git-p4: support multiple depot paths in p4 submit

From: Lars Schneider <larsxschneider@gmail.com>
Date: Dec 8, 2015, 09:48 UTC
Message-ID: <14B51656-26D1-4805-9F07-102CBD81B387@gmail.com>
In-Reply-To: <20151207185129.GA48528@hocevar.net>

On 07 Dec 2015, at 19:51, Sam Hocevar <sam@hocevar.net> wrote:

Show 12 quoted lines

> On Sun, Dec 06, 2015, Lars Schneider wrote:
>> Thanks for the patch! Do you see a way to demonstrate the bug in a test case similar to t9821 [1]?
> 
>   Not yet, I'm afraid. It's proving trickier than expected because for
> now I can only reproduce the bug when the view uses multiples depots
> (solution #2 on http://answers.perforce.com/articles/KB/2437), and
> unfortunately the test case system in Git was designed for a single
> depot.
> 
>   Would a refactor of lib-git-p4.sh (and probably all git-p4 tests) to
> support multiple depots be acceptable and/or welcome? I prefer to ask
> before I dig into the task.

Can you outline your idea a bit? Are you aware of the following way to define client specs: [1] ? Would that help? I haven't used multiple depots, yet. Therefore please bare with me :-)

Thanks, Lars

[1] https://github.com/git/git/blob/362d2fc2f8ab9ee22072f76fb36ec16918511944/t/t9821-git-p4-path-variations.sh#L109-L111