git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] verify_pack: do not ignore return value of verification function

From
Jeff King <peff@peff.net>
Date
Dec 1, 2015, 23:28 UTC
Message-ID
<20151201232804.GC13245@sigill.intra.peff.net>
In-Reply-To
<1448923662-24725-1-git-send-email-dturner@twopensource.com>
On Mon, Nov 30, 2015 at 05:47:42PM -0500, David Turner wrote:
Show 14 quoted lines
> In verify_pack, a caller-supplied verification function is called.
> The function returns an int.  If that return value is non-zero,
> verify_pack should fail.
> 
> The only caller of verify_pack is in builtin/fsck.c, whose verify_fn
> returns a meaningful error code (which was then ignored).  Now, fsck
> might return a different error code (with more detail).  This would
> happen in the unlikely event that a commit or tree that is a valid git
> object but not a valid instance of its type gets into a pack.
> 
> Signed-off-by: David Turner <dturner@twopensource.com>
> ---
>  pack-check.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, this looks good to me.
-Peff
Previous: David Turner
Message 2 of 2 in “verify_pack: do not ignore return value of verification function”
  1. verify_pack: do not ignore return value of verification functionDavid Turner, Nov 30, 2015
  2. Jeff KingDec 1, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.