From: Jeff King <peff@peff.net>
Date: Tue, 01 Dec 2015 23:28:04 GMT
Subject: Re: [PATCH] verify_pack: do not ignore return value of verification function
Message-ID: <20151201232804.GC13245@sigill.intra.peff.net>
In-Reply-To: <1448923662-24725-1-git-send-email-dturner@twopensource.com>

On Mon, Nov 30, 2015 at 05:47:42PM -0500, David Turner wrote:

> In verify_pack, a caller-supplied verification function is called.
> The function returns an int.  If that return value is non-zero,
> verify_pack should fail.
> 
> The only caller of verify_pack is in builtin/fsck.c, whose verify_fn
> returns a meaningful error code (which was then ignored).  Now, fsck
> might return a different error code (with more detail).  This would
> happen in the unlikely event that a commit or tree that is a valid git
> object but not a valid instance of its type gets into a pack.
> 
> Signed-off-by: David Turner <dturner@twopensource.com>
> ---
>  pack-check.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, this looks good to me.

-Peff