git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 0/6] Add Travis CI support

From
Jeff King <peff@peff.net>
Date
Nov 23, 2015, 18:59 UTC
Message-ID
<20151123185943.GE2597@sigill.intra.peff.net>
In-Reply-To
<CAE5ih7-q9JpiAW3pU6XWk+z0sGY8ej+UKEaR0bGuBnR0D9+P5A@mail.gmail.com>
On Fri, Nov 20, 2015 at 12:56:04PM +0000, Luke Diamand wrote:
Show 15 quoted lines
> >>>  git-p4: retry kill/cleanup operations in tests with timeout
> >>>  git-p4: add p4d timeout in tests
> >>>  git-p4: add trap to kill p4d on test exit
> >>
> >> These are all fairly gross, and I don't have p4d to test with myself.
> >> But if we assume they're all necessary, I suppose it's the best we can
> >> do.
> >
> > Unfortunately I think they are necessary. However, if someone finds a better way for stable p4d tests then I would be happy to see them go away, again.
> 
> I think that's just how p4d is I'm afraid. It doesn't like being
> stopped and started quickly (I guess it's not a normal use-case for
> most p4 users). I've made various unsuccessful attempts in the past to
> make these tests work reliably, and Lars' changes are far better than
> anything I ever managed.

Thanks for the extra context. I hope I didn't sound too negative in my initial assessment. It was meant to be "this is lamentable but probably necessary".

-Peff
Previous: Luke DiamandNext: Luke Diamand
Message 13 of 14 in “Add Travis CI support”
  1. 0/6 Add Travis CI supportlarsxschneider@gmail.com, Nov 19, 2015
  2. 1/6 implement test_might_fail using a refactored test_must_faillarsxschneider@gmail.com, Nov 19, 2015
  3. 2/6 add "ok=sigpipe" to test_must_fail and use it to fix flaky testslarsxschneider@gmail.com, Nov 19, 2015
  4. 3/6 git-p4: retry kill/cleanup operations in tests with timeoutlarsxschneider@gmail.com, Nov 19, 2015
  5. 4/6 git-p4: add p4d timeout in testslarsxschneider@gmail.com, Nov 19, 2015
  6. 5/6 git-p4: add trap to kill p4d on test exitlarsxschneider@gmail.com, Nov 19, 2015
  7. 6/6 Add Travis CI supportlarsxschneider@gmail.com, Nov 19, 2015
  8. Jeff KingNov 19, 2015
  9. Lars SchneiderNov 20, 2015
  10. Jeff KingNov 19, 2015
  11. Lars SchneiderNov 20, 2015
  12. Luke DiamandNov 20, 2015
  13. Jeff KingNov 23, 2015
  14. Luke DiamandNov 23, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.