git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v6 5/6] git-p4: add trap to kill p4d on test exit

From
larsxschneider@gmail.com <larsxschneider@gmail.com>
Date
Nov 19, 2015, 08:58 UTC
Message-ID
<1447923491-15330-6-git-send-email-larsxschneider@gmail.com>
In-Reply-To
<1447923491-15330-1-git-send-email-larsxschneider@gmail.com>
From: Lars Schneider <larsxschneider@gmail.com>

Sometimes the "prove" test runner hangs on test exit because p4d is still running. Add a trap to always kill "p4d" on test exit.

You can reproduce the problem by commenting "P4D_TIMEOUT" in "lib-git-p4.sh" and running "prove ./t9800-git-p4-basic.sh".

Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
---
 t/lib-git-p4.sh | 9 +++++++++
 1 file changed, 9 insertions(+)
diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
index acd5578..f9ae1d7 100644
--- a/t/lib-git-p4.sh
+++ b/t/lib-git-p4.sh
@@ -74,6 +74,15 @@ cli="$TRASH_DIRECTORY/cli"
 git="$TRASH_DIRECTORY/git"
 pidfile="$TRASH_DIRECTORY/p4d.pid"

+# Sometimes "prove" seems to hang on exit because p4d is still running
+cleanup() {
+	if test -f "$pidfile"
+	then
+		kill -9 $(cat "$pidfile") 2>/dev/null && exit 255
+	fi
+}
+trap cleanup EXIT
+
 # git p4 submit generates a temp file, which will
 # not get cleaned up if the submission fails.  Don't
 # clutter up /tmp on the test machine.
--
2.5.1
Previous: larsxschneider@gmail.comNext: larsxschneider@gmail.com
Message 6 of 14 in “Add Travis CI support”
  1. 0/6 Add Travis CI supportlarsxschneider@gmail.com, Nov 19, 2015
  2. 1/6 implement test_might_fail using a refactored test_must_faillarsxschneider@gmail.com, Nov 19, 2015
  3. 2/6 add "ok=sigpipe" to test_must_fail and use it to fix flaky testslarsxschneider@gmail.com, Nov 19, 2015
  4. 3/6 git-p4: retry kill/cleanup operations in tests with timeoutlarsxschneider@gmail.com, Nov 19, 2015
  5. 4/6 git-p4: add p4d timeout in testslarsxschneider@gmail.com, Nov 19, 2015
  6. 5/6 git-p4: add trap to kill p4d on test exitlarsxschneider@gmail.com, Nov 19, 2015
  7. 6/6 Add Travis CI supportlarsxschneider@gmail.com, Nov 19, 2015
  8. Jeff KingNov 19, 2015
  9. Lars SchneiderNov 20, 2015
  10. Jeff KingNov 19, 2015
  11. Lars SchneiderNov 20, 2015
  12. Luke DiamandNov 20, 2015
  13. Jeff KingNov 23, 2015
  14. Luke DiamandNov 23, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.