git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/1] Makefile: make curl-config path configurable

From
Remi Pommarel <repk@triplefau.lt>
Date
Oct 5, 2015, 21:05 UTC
Message-ID
<20151005210545.GC386@cruxbox>
In-Reply-To
<20151005204909.GE11993@google.com>
On Mon, Oct 05, 2015 at 01:49:09PM -0700, Jonathan Nieder wrote:
Show 7 quoted lines
> Remi Pommarel wrote:
> 
> > Signed-off-by: Remi Pommarel <repk@triplefau.lt>
> 
> For what it's worth, with or without the tweaks below,
> 
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
Show 18 quoted lines
> 
> [...]
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -39,6 +39,10 @@ all::
> >  # Define CURLDIR=/foo/bar if your curl header and library files are in
> >  # /foo/bar/include and /foo/bar/lib directories.
> >  #
> > +# Define CURL_CONFIG to curl's configuration program that gives informations
> > +# about the library (ie curl's version, cflags, ...) . If not set it defaults
> > +# to 'curl-config'.
> 
> Extra spaces, some wording tweaks:
> 
> s/gives informations about the library/prints information about the library/
> s/(ie curl's version, cflags, .../) /(e.g., its version number)/
> s/If not set it defaults to/The default is/
> 

Do I need to resend a v4 patch with these modifications ? I am not sure about the correct workflow here.

-- 
Rémi
Previous: Jonathan NiederNext: Jonathan Nieder
Message 3 of 5 in “Makefile: make curl-config path configurable”
  1. 1/1 Makefile: make curl-config path configurableRemi Pommarel, Oct 5, 2015
  2. Jonathan NiederOct 5, 2015
  3. Remi PommarelOct 5, 2015
  4. Jonathan NiederOct 5, 2015
  5. Remi PommarelOct 5, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.