Re: [PATCH v3 1/1] Makefile: make curl-config path configurable

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 5, 2015, 20:49 UTC
Message-ID: <20151005204909.GE11993@google.com>
In-Reply-To: <1444077159-3268-1-git-send-email-repk@triplefau.lt>

Remi Pommarel wrote:

> Signed-off-by: Remi Pommarel <repk@triplefau.lt>

For what it's worth, with or without the tweaks below,

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

[...]

Show 9 quoted lines

> --- a/Makefile
> +++ b/Makefile
> @@ -39,6 +39,10 @@ all::
>  # Define CURLDIR=/foo/bar if your curl header and library files are in
>  # /foo/bar/include and /foo/bar/lib directories.
>  #
> +# Define CURL_CONFIG to curl's configuration program that gives informations
> +# about the library (ie curl's version, cflags, ...) . If not set it defaults
> +# to 'curl-config'.

Extra spaces, some wording tweaks:

s/gives informations about the library/prints information about the library/ s/(ie curl's version, cflags, .../) /(e.g., its version number)/ s/If not set it defaults to/The default is/

Thanks.

diff --git i/Makefile w/Makefile
index 5a94434..4a870a4 100644
--- i/Makefile
+++ w/Makefile
@@ -39,9 +39,8 @@ all::
 # Define CURLDIR=/foo/bar if your curl header and library files are in
 # /foo/bar/include and /foo/bar/lib directories.
 #
-# Define CURL_CONFIG to curl's configuration program that gives informations
-# about the library (ie curl's version, cflags, ...) . If not set it defaults
-# to 'curl-config'.
+# Define CURL_CONFIG to curl's configuration program that prints information
+# about the library (e.g., its version number).  The default is 'curl-config'.
 #
 # Define NO_EXPAT if you do not have expat installed.  git-http-push is
 # not built, and you cannot push using http:// and https:// transports (dumb).