git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 2/3] run-commands: add an async queue processor

From
Jeff King <peff@peff.net>
Date
Aug 21, 2015, 19:44 UTC
Message-ID
<20150821194454.GB26466@sigill.intra.peff.net>
In-Reply-To
<xmqqegiw5uom.fsf@gitster.dls.corp.google.com>
On Fri, Aug 21, 2015 at 12:05:13PM -0700, Junio C Hamano wrote:
Show 7 quoted lines
> The primary reason I suspect is because you sent to a wrong set of
> people.  Submodule folks have largely been working in the scripted
> ones, and may not necessarily be the ones who are most familiar with
> the run-command infrastructure.
> 
> "shortlog --no-merges" tells me that the obvious suspects are j6t
> and peff.
No good deed goes unpunished. ;)

Before even looking at the implementation, my first question would be whether this pattern is applicable in several places in git (i.e., is it worth the extra complexity of abstracting out in the first place). I think there are a few task-queue patterns already in git; for example the delta search in pack-objects. Is the interface given here sufficient to convert pack-objects? Is the result nicer to read? Is it as efficient?

We do not need to convert all possible call-sites to the new abstracted code at once. But I find that converting at least _one_ is a good litmus test to confirm that a new interface is generally useful.

-Peff
Previous: Junio C HamanoNext: Stefan Beller
Message 4 of 16 in “submodule: implement `module_clone` as a builtin helper”
  1. 1/3 submodule: implement `module_clone` as a builtin helperStefan Beller, Aug 21, 2015
  2. 2/3 run-commands: add an async queue processorStefan Beller, Aug 21, 2015
  3. Junio C HamanoAug 21, 2015
  4. Jeff KingAug 21, 2015
  5. Stefan BellerAug 21, 2015
  6. Jeff KingAug 21, 2015
  7. Stefan BellerAug 21, 2015
  8. Junio C HamanoAug 21, 2015
  9. Stefan BellerAug 21, 2015
  10. Junio C HamanoAug 24, 2015
  11. Stefan BellerAug 21, 2015
  12. Junio C HamanoAug 21, 2015
  13. Stefan BellerAug 21, 2015
  14. 3/3 submodule: helper to run foreach in parallelStefan Beller, Aug 21, 2015
  15. Junio C HamanoAug 21, 2015
  16. Stefan BellerAug 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.