Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

From: Johannes Löthberg <johannes@kyriasis.com>
Date: Jun 20, 2015, 18:13 UTC
Message-ID: <20150620181348.GA28776@leeloo.kyriasis.com>
In-Reply-To: <xmqqr3p6jltx.fsf@gitster.dls.corp.google.com>

On 20/06, Junio C Hamano wrote:

Show 17 quoted lines

>Johannes Löthberg <johannes@kyriasis.com> writes:
>
>> On 15/06, Junio C Hamano wrote:
>>>You would probably want new tests, but more importantly did you make
>>>sure this passes existing tests?  It seems to break 5509 (there
>>>could be others) at least for me.
>>>
>>
>> It breaks 5509 currently yeah, though I've already fixed it locally.
>>
>> Anyway,
>>
>> You create a namespace by pushing to it,...
>
>You keep repeating that, but I do not think we agreed that it is the
>supported or correct procedure to set up a new namespace in the
>first place.

Whether it's 'correct' I can't say, but it's the only currently supported way.

>Doesn't the server side need a lot more than just
>setting up HEAD symref (like running upload/receive-pack with the
>path to the hierarchy exported as GIT_NAMESPACE environment)?

All it needs to do is use the refs under the ref namespace, and that it has already done for a long time. (Since 2011 in fact.)

-- 
Sincerely,
  Johannes Löthberg
  PGP Key ID: 0x50FB9B273A9D0BB5
  https://theos.kyriasis.com/~kyrias/