Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

From: Johannes Löthberg <johannes@kyriasis.com>
Date: Jun 12, 2015, 22:32 UTC
Message-ID: <20150612223223.GA22677@leeloo.kyriasis.com>
In-Reply-To: <1434147436-21272-1-git-send-email-johannes@kyriasis.com>

On 13/06, Johannes Löthberg wrote:

Show 16 quoted lines

>Git should fail to clone if trying to clone from an non-existing
>ref namespace, since it's the same as a non-existing repository
>
>Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
>---
>
>Changes since v1:
>
>* Fixed the namespace check, since I apparently forgot to check with a
>  bare repo in my last test. D'oh.
>
>Two other options for this would be to either add a
>get_git_namespace_len() function and use that, or a is_namespaced()
>functon. But since it's only used here for now at least it feels simpler
>to not bloat the codabase with another function which has no other use.
>

I should note that I have a small test script written now, ready to be converted into a git test, though I want some opinions on whether the patch would be merged before bothering to convert it.

-- 
Sincerely,
  Johannes Löthberg
  PGP Key ID: 0x50FB9B273A9D0BB5
  https://theos.kyriasis.com/~kyrias/