git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re: [PATCH v3 0/4] submodule config lookup API

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
May 26, 2015, 15:24 UTC
Message-ID
<20150526152402.GA31115@book.hvoigt.net>
In-Reply-To
<555E28E3.5020003@web.de>
On Thu, May 21, 2015 at 08:50:11PM +0200, René Scharfe wrote:
Show 13 quoted lines
> Am 21.05.2015 um 19:06 schrieb Heiko Voigt:
> >diff --git a/submodule-config.h b/submodule-config.h
> >index 9061e4e..58afc83 100644
> >--- a/submodule-config.h
> >+++ b/submodule-config.h
> >@@ -24,6 +24,6 @@ const struct submodule *submodule_from_name(const unsigned char *commit_sha1,
> >  		const char *name);
> >  const struct submodule *submodule_from_path(const unsigned char *commit_sha1,
> >  		const char *path);
> >-void submodule_free(void);
> >+void submodule_free();
> 
> Why this change?  With void it matches the function's definition.

Sorry oversight on my side will remove it. Junio added those on his side but it seems I forgot it in the header.

Cheers Heiko
Previous: René Scharfe
Message 9 of 9 in “submodule config lookup API”
  1. 0/4 submodule config lookup APIHeiko Voigt, May 21, 2015
  2. 1/4 implement submodule config cache for lookup of submodule namesHeiko Voigt, May 21, 2015
  3. 2/4 extract functions for submodule config set and lookupHeiko Voigt, May 21, 2015
  4. 3/4 use new config API for worktree configurations of submodulesHeiko Voigt, May 21, 2015
  5. 4/4 do not die on error of parsing fetchrecursesubmodules optionHeiko Voigt, May 21, 2015
  6. Junio C HamanoMay 21, 2015
  7. Heiko VoigtMay 26, 2015
  8. René ScharfeMay 21, 2015
  9. Heiko VoigtMay 26, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.