From: Heiko Voigt Date: Tue, 26 May 2015 15:24:02 GMT Subject: Re: Re: [PATCH v3 0/4] submodule config lookup API Message-ID: <20150526152402.GA31115@book.hvoigt.net> In-Reply-To: <555E28E3.5020003@web.de> On Thu, May 21, 2015 at 08:50:11PM +0200, René Scharfe wrote: > Am 21.05.2015 um 19:06 schrieb Heiko Voigt: > >diff --git a/submodule-config.h b/submodule-config.h > >index 9061e4e..58afc83 100644 > >--- a/submodule-config.h > >+++ b/submodule-config.h > >@@ -24,6 +24,6 @@ const struct submodule *submodule_from_name(const unsigned char *commit_sha1, > > const char *name); > > const struct submodule *submodule_from_path(const unsigned char *commit_sha1, > > const char *path); > >-void submodule_free(void); > >+void submodule_free(); > > Why this change? With void it matches the function's definition. Sorry oversight on my side will remove it. Junio added those on his side but it seems I forgot it in the header. Cheers Heiko