git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] git-verify-pack.txt: fix inconsistent spelling of "packfile"

From
Jeff King <peff@peff.net>
Date
May 21, 2015, 02:04 UTC
Message-ID
<20150521020402.GA11619@peff.net>
In-Reply-To
<xmqqzj4ylvto.fsf@gitster.dls.corp.google.com>
On Wed, May 20, 2015 at 03:37:23PM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> In any case, even though I merged these three to 'next', I think we
> need to either revert 3/3 or do s/pack-file/packfile/ throughout the
> pack-protocol documentation.  The original has something like this:
> 
>     The pack-file MUST NOT be sent if the only command used is 'delete'.
> 
>     A pack-file MUST be sent if either create or update command is used,
>     even if the server already has all the necessary objects.  In this
>     case the client MUST send an empty pack-file.   The only time this
>     is likely to happen is if the client is creating
>     a new branch or a tag that points to an existing obj-id.
> 
> and these are explicitly referring to what EBNF defines as "pack-file".
> Changing them to "packfile" is simply wrong.

Yeah, I agree they should agree with the EBNF. And my inclination is for "packfile", as it is refering to the concept of the on-the-wire packfile data (there is no "file ending in .pack" in this context).

Which I guess argues for a further patch.
-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 10 of 17 in “git-verify-pack.txt: fix inconsistent spelling of "packfile"”
  1. 1/3 git-verify-pack.txt: fix inconsistent spelling of "packfile"Patrick Steinhardt, May 17, 2015
  2. 2/3 git-unpack-objects.txt: fix inconsistent spelling of "packfile"Patrick Steinhardt, May 17, 2015
  3. 3/3 pack-protocol.txt: fix insconsistent spelling of "packfile"Patrick Steinhardt, May 17, 2015
  4. Junio C HamanoMay 19, 2015
  5. Jeff KingMay 19, 2015
  6. Junio C HamanoMay 20, 2015
  7. Junio C HamanoMay 20, 2015
  8. Jeff KingMay 20, 2015
  9. Junio C HamanoMay 20, 2015
  10. Jeff KingMay 21, 2015
  11. Junio C HamanoMay 21, 2015
  12. doc: fix inconsistent spelling of "packfile"Patrick Steinhardt, May 21, 2015
  13. Junio C HamanoMay 21, 2015
  14. Patrick SteinhardtMay 22, 2015
  15. doc: fix inconsistent spelling of "packfile"Patrick Steinhardt, May 22, 2015
  16. Junio C HamanoMay 22, 2015
  17. Patrick SteinhardtMay 20, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.