git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Diffing submodule does not yield complete logs for merge commits

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
May 19, 2015, 10:44 UTC
Message-ID
<20150519104413.GA17458@book.hvoigt.net>
In-Reply-To
<CAHd499CETM2jmZ2iJk=AoXtjLUCQ==u6q9Z5P-3EVGSY48FY_A@mail.gmail.com>
On Mon, May 18, 2015 at 10:06:32AM -0500, Robert Dailey wrote:
Show 6 quoted lines
> Unfortunately I find it unintuitive and counter productive to perform
> inline patches or do anything on a mailing list. Especially on
> Windows, it's a pain to setup git to effectively do this. Also I read
> mailing lists through Gmail which does not offer a proper monospace
> font view or syntax coloring to effectively review patches and
> comments pertaining to them.

Are you sure you are not overestimating the effort it takes to send patches inline? Once you've got your user agent correctly setup its just a matter of copy and paste instead of attaching the patch. On Windows I would probably use Thunderbird which has a section in the format-patch documentation how to configure it. Compared to the effort you probably spent on writing your patch isn't this bit of extra effort neglectable? And your patch is almost done. It just needs some tests and maybe a few rounds on the mailinglist after that.

> Since I am not willing to properly follow your process, I will
> withdraw my patch. However it is here if someone else wishes to take
> it over. Really wish you guys used github's amazing features but I
> understand that Linus has already made his decision in that matter.

It not just Linus decision it is also a matter of many people are used to this workflow. AFAIR there have been many discussions and tries about using other tools. Email has many advantages which a webinterface does not provide. It is simply less effort that one person adjusts to this workflow instead of changing many peoples working workflow.

> I'm sorry I couldn't be more agreeable on the matter. Thanks for the
> time you spent reviewing my patch.
If you are really this fixed in your workflow that would be too bad.
Cheers Heiko
Previous: Robert DaileyNext: Robert Dailey
Message 11 of 24 in “Diffing submodule does not yield complete logs for merge commits”
  1. Robert DaileyApr 29, 2015
  2. Heiko VoigtMay 1, 2015
  3. Robert DaileyMay 4, 2015
  4. Jens LehmannMay 4, 2015
  5. Robert DaileyMay 4, 2015
  6. Heiko VoigtMay 4, 2015
  7. Johannes SchindelinMay 5, 2015
  8. Robert DaileyMay 15, 2015
  9. Heiko VoigtMay 18, 2015
  10. Robert DaileyMay 18, 2015
  11. Heiko VoigtMay 19, 2015
  12. Robert DaileyMay 19, 2015
  13. Stefan BellerMay 19, 2015
  14. Roberto TyleyMay 22, 2015
  15. Heiko VoigtMay 21, 2015
  16. Robert DaileyMay 30, 2015
  17. Heiko VoigtMay 30, 2015
  18. Junio C HamanoMay 30, 2015
  19. Robert DaileyMay 30, 2015
  20. Robert DaileyMay 30, 2015
  21. Junio C HamanoMay 30, 2015
  22. Robert DaileyMay 30, 2015
  23. Heiko VoigtJun 2, 2015
  24. Junio C HamanoMay 4, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.