Re: Diffing submodule does not yield complete logs for merge commits

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: May 4, 2015, 20:51 UTC
Message-ID: <20150504205104.GA28246@sandbox-ub1410>
In-Reply-To: <CAHd499CRge9Y6VzdC_ngXS4WxuQ9HizXQJzLpX3iQStY5Cg=6g@mail.gmail.com>

Hi,

On Mon, May 04, 2015 at 03:21:31PM -0500, Robert Dailey wrote:

Show 6 quoted lines

> Since I am not a linux user, I have implemented this feature against
> the Git for Windows fork of git. I am not able to verify changes if I
> make them directly against the Git repository. Is it OK if you guys
> end up getting this as an upstream patch later from that project? Also
> I am not familiar with the bash unit tests, I will need help with
> that.

I think there is nothing wrong with implementing it in the Windows development environment and then sending the patch directly here. As long as it is not Windows specific (which it should not be) that should be fine and you save the Windows guys the work to get the patch upstream (because here is upstream not there ;-)).

Have a look at some tests, they are quite simple. Basically they run git commands in a && chain and the resulting return code tells the testsuite whether that test succeeded or not. Maybe have a look at the test for the existing --submodule option (t4041-diff-submodule-option.sh) as an example. You can probably reuse the complete setup there and just add a new test for the new option with the expected output. There is also a README in the t/ folder. HTH.

Cheers Heiko