git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 01/16] refs: convert struct ref_entry to use struct object_id

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Apr 24, 2015, 22:36 UTC
Message-ID
<20150424223603.GA322887@vauxhall.crustytoothpaste.net>
In-Reply-To
<CAGZ79kbjBbuE=KGrW_7a7AOCGgEJgYb9fEE_MLq89ytkaBctRQ@mail.gmail.com>
On Wed, Apr 22, 2015 at 05:52:09PM -0700, Stefan Beller wrote:
Show 11 quoted lines
> So you're switching the code for a possible future
> In an earlier series/cover letter you wrote
> 
> > The goal of this series to improve type-checking in the codebase and to
> > make it easier to move to a different hash function if the project
> > decides to do that.  This series does not convert all of the codebase,
> > but only parts.  I've dropped some of the patches from earlier (which no
> > longer apply) and added others.
> 
> Which yields the question if you also want to take care of the error message
> (It may not be a SHA1 any more but some $HASHFUNCTION)?

This is true. However, I'll clean those up with a future patch series when we get to that point. I'll need to pass through the documentation as well to make it accurate and consistent, and I'll want to discuss the words we want to use before I make those changes.

> That said I'll focus on the type checking part in this review
> and not annotate the SHA1s I find any more. ;)

Please do comment on any hardcoded 20s or 40s (or quantities based off those), as I do want to fix those up. I want to fix up any hardcoded assumptions we may have about the hash that don't involve text or documentation at this point, if only for maintainability reasons.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Previous: Stefan BellerNext: brian m. carlson
Message 4 of 24 in “Convert parts of refs.c to struct object_id”
  1. 00/16 Convert parts of refs.c to struct object_idbrian m. carlson, Apr 22, 2015
  2. 01/16 refs: convert struct ref_entry to use struct object_idbrian m. carlson, Apr 22, 2015
  3. Stefan BellerApr 23, 2015
  4. brian m. carlsonApr 24, 2015
  5. 02/16 refs: convert for_each_tag_ref to struct object_idbrian m. carlson, Apr 22, 2015
  6. Stefan BellerApr 23, 2015
  7. Jeff KingApr 23, 2015
  8. brian m. carlsonApr 24, 2015
  9. 03/16 refs: convert remaining users of for_each_ref_in to object_idbrian m. carlson, Apr 22, 2015
  10. 04/16 refs: convert for_each_ref_in_submodule to object_idbrian m. carlson, Apr 22, 2015
  11. 05/16 refs: convert head_ref to struct object_idbrian m. carlson, Apr 22, 2015
  12. 06/16 refs: convert for_each_ref_submodule to struct object_idbrian m. carlson, Apr 22, 2015
  13. 07/16 revision: remove unused _oid helper.brian m. carlson, Apr 22, 2015
  14. 08/16 refs: convert for_each_ref to struct object_idbrian m. carlson, Apr 22, 2015
  15. 09/16 refs: convert for_each_replace_ref to struct object_idbrian m. carlson, Apr 22, 2015
  16. 10/16 refs: convert namespaced ref iteration functions to object_idbrian m. carlson, Apr 22, 2015
  17. 11/16 refs: convert for_each_rawref to struct object_id.brian m. carlson, Apr 22, 2015
  18. 12/16 refs: rename do_for_each_ref_oid to do_for_each_refbrian m. carlson, Apr 22, 2015
  19. 13/16 refs: convert for_each_reflog to struct object_idbrian m. carlson, Apr 22, 2015
  20. 14/16 refs: rename each_ref_fn_oid to each_ref_fnbrian m. carlson, Apr 22, 2015
  21. 15/16 Remove unneeded *_oid functions.brian m. carlson, Apr 22, 2015
  22. 16/16 refs: convert struct ref_lock to struct object_idbrian m. carlson, Apr 22, 2015
  23. Michael HaggertyApr 26, 2015
  24. brian m. carlsonMay 3, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.