git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] push --signed: tighten what the receiving end can ask to sign

From
Jeff King <peff@peff.net>
Date
Apr 2, 2015, 22:16 UTC
Message-ID
<20150402221603.GA13077@peff.net>
In-Reply-To
<xmqqlhiagp2s.fsf@gitster.dls.corp.google.com>
On Thu, Apr 02, 2015 at 03:09:15PM -0700, Junio C Hamano wrote:
Show 5 quoted lines
> +		if (isalnum(ch) ||
> +		    ch == '-' || ch == '.' ||
> +		    ch == '/' || ch == '+' ||
> +		    ch == '=' || ch == '_')
> +			continue;

I think this looks good. Earlier I suggested reducing the set of allowable punctuation characters, but if we want to allow base64, that's "+/=" right there. We use "-" ourselves, leaving only "." and "_" as possible extras. But both of those are as useful as "-" for separators, and are fairly innocuous, so I don't mind leaving them.

-Peff
Previous: Junio C Hamano
Message 2 of 2 in “push --signed: tighten what the receiving end can ask to sign”
  1. push --signed: tighten what the receiving end can ask to signJunio C Hamano, Apr 2, 2015
  2. Jeff KingApr 2, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.