From: Jeff King <peff@peff.net>
Date: Thu, 02 Apr 2015 22:16:03 GMT
Subject: Re: [PATCH] push --signed: tighten what the receiving end can ask to sign
Message-ID: <20150402221603.GA13077@peff.net>
In-Reply-To: <xmqqlhiagp2s.fsf@gitster.dls.corp.google.com>

On Thu, Apr 02, 2015 at 03:09:15PM -0700, Junio C Hamano wrote:

> +		if (isalnum(ch) ||
> +		    ch == '-' || ch == '.' ||
> +		    ch == '/' || ch == '+' ||
> +		    ch == '=' || ch == '_')
> +			continue;

I think this looks good. Earlier I suggested reducing the set of
allowable punctuation characters, but if we want to allow base64, that's
"+/=" right there. We use "-" ourselves, leaving only "." and "_" as
possible extras. But both of those are as useful as "-" for separators,
and are fairly innocuous, so I don't mind leaving them.

-Peff