Re: [PATCH v3] remote-curl: fall back to Basic auth if Negotiate fails

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Mar 10, 2015, 22:29 UTC
Message-ID: <20150310222907.GA36141@vauxhall.crustytoothpaste.net>
In-Reply-To: <E53D99DB-E894-4FA8-9351-39E23FFD677E@cisco.com>

On Tue, Mar 10, 2015 at 06:05:46PM +0000, Dan Langille (dalangil) wrote:

Show 13 quoted lines

>> We have made progress I think.
>>
>> With stock git:
>>
>> tl;dr: 1 - with a ticket, you get prompted, but hitting ENTER succeeds.
>>       2 - without a ticket, nothing works
>>
>>
>> With patched git:
>>
>> tl;dr: 1 - with a ticket,    entering credentials, SUCCEEDS; just hit enter, failure
>
>If I have a valid ticket, why am I being prompted for credentials?

libcurl won't even attempt authentication if you don't have a username specified. I know that the web server should be able to figure it out from your credentials, so it shouldn't matter what username you provide. This is an unfortuate quirk of libcurl.

Also, are you using 2.3.0, or one of the earlier patched versions? That might affect how it works.

>It appears patched git always wants credentials entered and ignores the
>valid ticket.

So what I think is happening is that you didn't specify a username, but git got a 401, so it prompted. Now it actually attempts to use the password you provided, whereas before it did not.

Does it work with a ticket if you specify a username, as in the following URL? https://bmc@git.crustytoothpaste.net/git/bmc/homedir.git

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187