Re: [PATCH] remote-curl: fall back to Basic auth if Negotiate fails.

From: Jeff King <peff@peff.net>
Date: Dec 27, 2014, 21:29 UTC
Message-ID: <20141227212948.GA30098@peff.net>
In-Reply-To: <20141227210935.GA10649@vauxhall.crustytoothpaste.net>

On Sat, Dec 27, 2014 at 09:09:36PM +0000, brian m. carlson wrote:

Show 7 quoted lines

> > I'm not familiar enough with Negotiate auth to do give a thorough review
> > on the logic above. But FWIW, it makes sense to me, and the code looks
> > correct.
> 
> libcurl will try very hard to use something other than Basic auth, even
> over HTTPS.  If Basic and something else are offered, libcurl will never
> use Basic.  I should probably make a note of that in the commit message.

Thanks, that does help explain things (to me, anyway).

The thing I am not sure of in your explanation is:

>>> since if they failed the first time, they will never succeed

Are there other GSSAPI methods where this is not the case? I don't know of any, and AFAICT git's support is used only for Kerberos, so this is probably safe for now. If somebody can produce a concrete case that behaves differently, we can untangle it then.

-Peff