Re: [PATCH 2/2] transport-helper: ask the helper to set the same options for import as for fetch
- From
Mike Hommey <mh@glandium.org>
- Date
- Feb 13, 2015, 22:14 UTC
- Message-ID
- <20150213221450.GA24285@glandium.org>
- In-Reply-To
- <xmqqwq3lmwnb.fsf@gitster.dls.corp.google.com>
On Fri, Feb 13, 2015 at 11:36:24AM -0800, Junio C Hamano wrote:
Show 11 quoted lines
> Mike Hommey <mh@glandium.org> writes: > > > A remote helper is currently only told about the 'check-connectivity', > > 'cloning', and 'update-shallow' options when it supports the 'fetch' > > command, but not when it supports 'import' instead. > > Sounds sensible. > > Does the same issue exist for export vs push or do they happen to be > coded to pass similar enough set of options already by copied and > pasted code?
The issue exists: - export is given dry-run, pushcert and force. - push is given cas, dry-run and pushcert.
(note: cas and pushcert are both not documented in gitremote-helpers.txt)
Force is actually not necessary for push, because the push syntax itself includes the force instruction in the refspec given as argument.
I haven't looked exactly what cas does and if it makes sense for export. (FWIW, I'm using push and import at the moment, so it's not a direct issue for me ; I don't support cas anyways)
Mike