git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] transport-helper: emit check-connectivity, cloning, and update-shallow options for import

From
Mike Hommey <mh@glandium.org>
Date
Feb 12, 2015, 10:10 UTC
Message-ID
<1423735801-11108-2-git-send-email-mh@glandium.org>
In-Reply-To
<1423735801-11108-1-git-send-email-mh@glandium.org>

The check-connectivity, cloning, and update-shallow options are currently only emitted for the fetch command but should also be emitted for the import command.

Signed-off-by: Mike Hommey <mh@glandium.org>
---
 transport-helper.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index 23a741c..c3868e4 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -342,16 +342,6 @@ static int fetch_with_fetch(struct transport *transport,
 	int i;
 	struct strbuf buf = STRBUF_INIT;
 
-	if (data->check_connectivity &&
-	    data->transport_options.check_self_contained_and_connected)
-		set_helper_option(transport, "check-connectivity", "true");
-
-	if (transport->cloning)
-		set_helper_option(transport, "cloning", "true");
-
-	if (data->transport_options.update_shallow)
-		set_helper_option(transport, "update-shallow", "true");
-
 	for (i = 0; i < nr_heads; i++) {
 		const struct ref *posn = to_fetch[i];
 		if (posn->status & REF_STATUS_UPTODATE)
@@ -622,6 +612,16 @@ static int fetch(struct transport *transport,
 	if (!count)
 		return 0;
 
+	if (data->check_connectivity &&
+	    data->transport_options.check_self_contained_and_connected)
+		set_helper_option(transport, "check-connectivity", "true");
+
+	if (transport->cloning)
+		set_helper_option(transport, "cloning", "true");
+
+	if (data->transport_options.update_shallow)
+		set_helper_option(transport, "update-shallow", "true");
+
 	if (data->fetch)
 		return fetch_with_fetch(transport, nr_heads, to_fetch);
 
-- 
2.3.0.1.g55ac403.dirty
Previous: Mike HommeyNext: Mike Hommey
Message 2 of 11 in “transport-helper: emit progress and verbosity options after asking for capabilities”
  1. 1/3 transport-helper: emit progress and verbosity options after asking for capabilitiesMike Hommey, Feb 12, 2015
  2. 2/3 transport-helper: emit check-connectivity, cloning, and update-shallow options for importMike Hommey, Feb 12, 2015
  3. 3/3 transport-helper: fix typo in error message when --signed is not supportedMike Hommey, Feb 12, 2015
  4. Mike HommeyFeb 12, 2015
  5. Junio C HamanoFeb 12, 2015
  6. Junio C HamanoFeb 12, 2015
  7. 1/2 transport-helper: ask the helper to set progress and verbosity options after asking for its capabilitiesMike Hommey, Feb 13, 2015
  8. 2/2 transport-helper: ask the helper to set the same options for import as for fetchMike Hommey, Feb 13, 2015
  9. Junio C HamanoFeb 13, 2015
  10. Mike HommeyFeb 13, 2015
  11. Junio C HamanoFeb 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.