Re: [PATCH] contrib/completion: suppress stderror in bash
- From
SZEDER Gábor <szeder@ira.uka.de>
- Date
- Feb 10, 2015, 02:10 UTC
- Message-ID
- <20150210031008.Horde.1WYJ_81O2E96Rgv2xrVmqw1@webmail.informatik.kit.edu>
- In-Reply-To
- <xmqqy4o6aj1w.fsf@gitster.dls.corp.google.com>
Hi,
Quoting Junio C Hamano <gitster@pobox.com>:
> Matt Korostoff <mkorostoff@gmail.com> writes:
Show 15 quoted lines
>> diff --git a/contrib/completion/git-completion.bash
>> b/contrib/completion/git-completion.bash
>> index 2fece98..72251cc 100644
>> --- a/contrib/completion/git-completion.bash
>> +++ b/contrib/completion/git-completion.bash
>> @@ -412,7 +412,7 @@ __git_refs_remotes ()
>> __git_remotes ()
>> {
>> local i IFS=$'\n' d="$(__gitdir)"
>> - test -d "$d/remotes" && ls -1 "$d/remotes"
>> + test -d "$d/remotes" && ls -1 "$d/remotes" 2>/dev/null
>> for i in $(git --git-dir="$d" config --get-regexp
>> 'remote\..*\.url' 2>/dev/null); do
>> i="${i#remote.}"
>> echo "${i/.url*/}"Do I smell some bitrotting here?
This function just lists all the defined remotes, first by listing the directories under refs/remotes to get the "legacy" remotes and then loops over 'git config's output to get the "modern" ones. This predates the arrival of the 'git remote' command in January 2007, so it was really a long time ago.
We should just run 'git remote' instead, shouldn't we?
Cheers, Gábor